Repository navigation
refactor: cut comments in the MCP packages down to the ones that explain why - #495
Merged
emaarco merged 1 commit intoOct 28, 2026
Merged
Conversation
emaarco
enabled auto-merge (squash)
October 28, 2026 08:54
✅ Deploy Preview for spectacular-cobbler-f6c85b ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
emaarco
deleted the
emaarco/refactor-cut-comments-in-the-mcp-packages-down-t
branch
October 28, 2026 09:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
About a fifth of the source lines in the MCP packages were comments, and many of them only repeated the code or copied a rule from the root
CLAUDE.md, so the same rule lived in several places that drift apart. This change reduces the comments to the reasons that no name and no test can show.What
analytics-client(~1,150 → ~290),analytics-connector(1,640 → ~620),widget-shell(5,021 → ~1,390) andcamunda7-connector(6,024 → ~1,870), tests included.CLAUDE.mdrules; shortened multi-line JSDoc blocks to the reason they carry, usually one line.increase()misses a born series, that a suspended handler resumes under the original token, the engine config precedence, and what catalogue drift does.camunda7-connectorafter an inline comment was removed.Verification
pnpm build,pnpm typecheck,pnpm test(incl. tools/list goldens and docs refs),pnpm lintandpnpm format:checkpass from the repo root.git diff -U0checked for changed lines outside comments: only multi-line comment continuations and the one prettier reflow.test:hostandtest:pg; no widget or Postgres code changed.widget-shellandcamunda7-connector.Out of scope / Follow-ups
Closes #491