Skip to content

fix(captcha): handle provider load failures #6584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SeniorZhai wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix(captcha): handle provider load failures #6584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f639e93
fix(captcha): handle provider load failures
SeniorZhai Aug 17, 2026
74a07f0
Merge remote-tracking branch 'origin/master' into fix/captcha-provide…
SeniorZhai Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 121 additions & 22 deletions app/src/main/assets/captcha.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,48 +18,147 @@
</style>
#gt
<script type="text/javascript">
var captchaLoadId = '#loadId';

var postToken = function (response) {
window.MixinContext.postToken(response);
window.MixinContext.postToken(captchaLoadId, response);
}

var postMessage = function (value) {
window.MixinContext.postMessage(value);
var errorDetail = function (error) {
if (error == null) return '';
if (typeof error === 'string') return error;
if (error.name || error.message) {
return [error.name, error.message].filter(Boolean).join(': ');
}
try {
return JSON.stringify(error);
} catch (_) {
return String(error);
}
}

var postEvent = function (event, stage, detail) {
window.MixinContext.postEvent(captchaLoadId, event, stage, errorDetail(detail));
}

var fatalEventPosted = false;

var postError = function (stage, error) {
if (fatalEventPosted) return;
fatalEventPosted = true;
postEvent('error', stage, error);
}

var onCaptchaScriptError = function () {
postError('script_load', 'load_failed');
}

window.addEventListener('error', function (event) {
var target = event.target;
if (target && target.tagName === 'SCRIPT' && target.src && target.src.indexOf('/api.js') !== -1) {
onCaptchaScriptError();
return;
}
if (!target || target === window) {
var source = event.filename ? event.filename.split('?')[0].split('/').pop() : '';
postError('javascript_error', [event.message, source, event.lineno, event.colno].filter(Boolean).join(':'));
}
}, true);

window.addEventListener('unhandledrejection', function (event) {
postError('unhandled_rejection', event.reason);
});

var renderCallback = {
'sitekey': '#apiKey',
'callback': postToken,
'expired-callback': postMessage,
'error-callback': postMessage,
'expired-callback': function () {
postError('response_expired', 'expired');
},
'error-callback': function (error) {
postError('provider_error', error);
},
'chalexpired-callback': function () {
postError('challenge_expired', 'expired');
},
'open-callback': function () {
postEvent('ready', 'challenge_ready', '');
},
'close-callback': function () {
postEvent('cancel', 'challenge_closed', '');
},
'size': 'invisible'
}

var onGCaptchaLoad = function () {
grecaptcha.render('html_element', window.renderCallback);
grecaptcha.execute();
postEvent('progress', 'sdk_loaded', '');
var widgetID;
try {
widgetID = grecaptcha.render('html_element', window.renderCallback);
postEvent('progress', 'widget_rendered', widgetID);
} catch (error) {
postError('render', error);
return;
}
try {
grecaptcha.execute(widgetID);
} catch (error) {
postError('execute', error);
}
}

var onHCaptchaLoad = function () {
var widgetID = hcaptcha.render('html_element', window.renderCallback);
hcaptcha.execute(widgetID);
postEvent('progress', 'sdk_loaded', '');
var widgetID;
try {
widgetID = hcaptcha.render('html_element', window.renderCallback);
postEvent('progress', 'widget_rendered', widgetID);
} catch (error) {
postError('render', error);
return;
}
try {
hcaptcha.execute(widgetID);
} catch (error) {
postError('execute', error);
}
}

var gtInitialized = false;

var initGTCaptcha = function() {
initGeetest4({
captchaId: '#apiKey',
product: 'bind',
hideBar: ['close']
}, function(captcha) {
captcha.onReady(function(){
captcha.showCaptcha();
}).onSuccess(function(){
var result = captcha.getValidate();
postToken(JSON.stringify(result));
}).onClose(function () {
postMessage("gt_close");
if (gtInitialized) return;
gtInitialized = true;
postEvent('progress', 'sdk_loaded', '');
try {
initGeetest4({
captchaId: '#apiKey',
product: 'bind',
hideBar: ['close'],
onError: function (error) {
postError('provider_error', error);
}
}, function(captcha) {
postEvent('progress', 'widget_rendered', '');
captcha.onReady(function(){
try {
captcha.showCaptcha();
postEvent('ready', 'challenge_ready', '');
} catch (error) {
postError('execute', error);
}
}).onSuccess(function(){
var result = captcha.getValidate();
postToken(JSON.stringify(result));
}).onError(function (error) {
postError('provider_error', error);
}).onClose(function () {
postError('challenge_closed', 'gt_close');
});
});
});
} catch (error) {
postError('render', error);
}
};
</script>
</head>
Expand Down
42 changes: 42 additions & 0 deletions app/src/main/java/one/mixin/android/widget/CaptchaLoadDecision.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
package one.mixin.android.widget

internal enum class CaptchaLoadEvent {
PageFinished,
SdkLoaded,
WidgetRendered,
ChallengeReady,
FatalError,
}

internal sealed interface CaptchaLoadAction {
data object KeepWatching : CaptchaLoadAction

data object RestartWatchdog : CaptchaLoadAction

data class SwitchTo(val captchaType: CaptchaView.CaptchaType) : CaptchaLoadAction

data object Stop : CaptchaLoadAction
}

internal fun decideCaptchaLoadAction(
event: CaptchaLoadEvent,
captchaType: CaptchaView.CaptchaType,
failureCount: Int,
maxFailureCount: Int,
fallbackEnabled: Boolean,
): CaptchaLoadAction =
when (event) {
CaptchaLoadEvent.PageFinished -> CaptchaLoadAction.KeepWatching
CaptchaLoadEvent.SdkLoaded,
CaptchaLoadEvent.WidgetRendered,
-> CaptchaLoadAction.RestartWatchdog

CaptchaLoadEvent.ChallengeReady -> CaptchaLoadAction.RestartWatchdog
CaptchaLoadEvent.FatalError -> {
if (!fallbackEnabled || failureCount >= maxFailureCount) {
CaptchaLoadAction.Stop
} else {
CaptchaLoadAction.SwitchTo(captchaType.fallback())
}
}
}
Loading