Skip to content

Read the catalog's own word for what is internal #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
estebanzimanyi merged 1 commit into from
Aug 28, 2026
Merged

Read the catalog's own word for what is internal #348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tools/codegen_duck_udfs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,14 @@ def hetero_temporal_args(f):
def supported(f):
"""Reason string if NOT emittable (mirrors Spark's supported()), else None."""
name = f["name"]
if name.startswith("meos_internal") or (f.get("group") or "").startswith("meos_internal"):
# The catalog states the classification in `api`, derived from the @ingroup tag:
# public where a group exists and is not an internal one, internal otherwise —
# and a function stating NO group is internal. Reading the group's NAME instead
# re-derives that rule and gets the no-group case backwards: the string test finds
# nothing to match, so an internal function passes as public and a call to it is
# emitted against a symbol only a private header declares (trgeometry_merge, which
# broke the extension build). Read what the catalog decided.
if f.get("api") != "public":
return "internal"
if not f.get("sqlfn"):
return "no-sqlfn" # not user-facing SQL surface
Expand Down
Loading