perf(mosaic): skip proven regional depth reads - #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This targets complex terminal, desktop, game, and editor-shaped streams rather than
vkcube.vkcubeis intentionally not optimized or used as evidence.Why this is safe
The regional minimum is only used for aligned, little-endian, uncounted depth buffers and admitted fast Mosaic draws. Unsupported or strict/fallback work invalidates the summary. The second triangle in an admitted quad observes the first triangle's conservative update before using the fast path.
Evidence
Controlled four-physical-core runs using
ZPU_MAX_THREADS=4 tools/limited-cpus.sh:These are host-specific measurements, not a universal 4x guarantee.
Validation
zig fmt --checkgit diff --checkZPU_MAX_THREADS=4 tools/limited-cpus.sh zig buildZPU_MAX_THREADS=4 tools/limited-cpus.sh zig build testzig test src/vulkan/cpu_cube.zig -lc(25/25)zig test src/benchmark_vulkan_abi.zig -lc(27/27)zig test src/vulkan/driver.zig -lc(296/296)