docs(windowing): record trade and login window factories - #731
Merged
Merged
Conversation
WINDOWING.md still named src/windowing.rs and six factories. Trade replay and the login prompt now have their own factories, a group window's Windows AppUserModelID is MoonTerminal.<group>, and the detached-chart comment named a taskbar helper that does not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
docs/WINDOWING.mdstill told readers to open windows throughcrates/moon-ui-gpui/src/windowing.rsand listed six factories. The file lives atcrates/moon-ui-gpui/src/window/windowing.rs.trade_window_optionsandlogin_window_optionsare factories now. A trade window is an independent, taskbar-hidden chart replay with a minimum size and aNoFillroot. The login prompt is a standalone first window:MoonWindowFrame::toolchrome, the application icon, and a taskbar button, opened throughlogin_window_optionsrather thantool_window_options.On Windows a group window's AppUserModelID is
MoonTerminal.<group>when the group name is non-empty (group_app_id). Every other factory setsMoonTerminal.The detached-chart doc comment named
hide_window_from_taskbar. That function does not exist. The helper ishide_window_from_taskbar_soon. The module comment now includes the trade-window and login factories.How to verify
Compared the new sentences with
crates/moon-ui-gpui/src/window/windowing.rs,crates/moon-ui-gpui/src/window/login.rs, andcrates/moon-ui-gpui/src/trade_window/window.rsplusrender.rs. A clean-context review found no mismatch, so nothing was dropped.cargo fmt --all,cargo test --workspace -j 4, andcargo clippy -p moon-ui-gpui --bin moonterminal -j 4passed locally. Clippy still reports existing warnings in other files.