fix(agent-core-v2): retry with media-stripped projection on content-t… - #2996
Open
jekhy wants to merge 8 commits into
Open
fix(agent-core-v2): retry with media-stripped projection on content-t…#2996jekhy wants to merge 8 commits into
jekhy wants to merge 8 commits into
Conversation
…ype-invalid 400 A text-only model rejects media content blocks in history with a 400 'content.type is invalid' error, breaking the conversation after switching from a multimodal model. Detect the error via isUnsupportedContentTypeError and resend with the media-stripped projection, mirroring the existing image-format recovery path.
🦋 Changeset detectedLatest commit: 57ca8d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 029f9276fe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ojection A media-stripped resend rebuilt the request from the normal projection, dropping the structural repairs a preceding strict resend had applied: a history needing both (e.g. duplicate tool-use ids plus media) re-introduced the structural defect and could not recover, since the structural retry is gated on the normal projection. Rebuild media-stripped on the strict projection so the repairs ride along; healthy histories are unaffected because strict repairs only fire on anomalous history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ype-invalid 400
A text-only model rejects media content blocks in history with a 400 'content.type is invalid' error, breaking the conversation after switching from a multimodal model. Detect the error via isUnsupportedContentTypeError and resend with the media-stripped projection, mirroring the existing image-format recovery path.
Related Issue
Resolve #2986
Problem
What changed
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.