feat(vscode): add background task browser - #2998
Conversation
🦋 Changeset detectedLatest commit: 3bb33dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ad05a0709
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| planMode: false, | ||
| }); | ||
| useApprovalStore.getState().clearRequests(); | ||
| useTasksStore.getState().setTasks([]); |
There was a problem hiding this comment.
When a saved session is selected, the host announces its background tasks inside LoadKimiSessionHistory before returning the RPC result, but loadSession runs afterward and unconditionally replaces that announcement with an empty list here. Because no subsequent refresh occurs, restored completed tasks remain inaccessible and running tasks stay hidden until another lifecycle event arrives, defeating task recovery when reopening a session.
Useful? React with 👍 / 👎.
| .then((result) => { | ||
| if (!cancelled) setOutput(result.output); | ||
| }) | ||
| .catch((loadError: unknown) => { | ||
| if (!cancelled) setError(loadError instanceof Error ? loadError.message : String(loadError)); |
There was a problem hiding this comment.
If any output poll fails transiently, this sets error, but a later successful interval only updates output and never clears that error. Since the render path prioritizes non-null error, a running task continues showing the stale failure even after subsequent polls succeed, until the user collapses and reopens the output.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ad05a0709
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [Methods.ListBackgroundTasks]: async (_, ctx): Promise<BackgroundTaskInfo[]> => { | ||
| const runtime = ctx.getSession(); | ||
| if (runtime === undefined) return []; | ||
| const tasks = await runtime.session.listBackgroundTasks({ activeOnly: false }); |
There was a problem hiding this comment.
When a subagent launches its own background Bash, agent, or question task under the default v2 engine, SessionRuntime receives and displays that lifecycle event because the SDK session subscribes to every agent in the session, but these APIs operate only on the interactive main agent. Consequently, refreshing removes the subagent task, reading its output returns empty, and clicking Stop is a no-op while the advertised task keeps running; preserve the event's agentId and route list/output/stop to that owner (or restrict displayed events to tasks these handlers can control).
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb584c53a8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| refreshTasks: async () => { | ||
| const tasks = await bridge.listBackgroundTasks(); | ||
| set({ tasks }); |
There was a problem hiding this comment.
When a task starts or terminates while listBackgroundTasks() is in flight, the lifecycle broadcast can update the store before the older RPC snapshot resolves, after which this unconditional set overwrites the newer state. Opening or manually refreshing the modal during a transition can therefore hide a newly started task or show a stopped task as running until another event or refresh occurs; discard superseded responses or merge them against lifecycle updates received after the request began.
Useful? React with 👍 / 👎.
| useEffect(() => { | ||
| const unsubs = [ | ||
| bridge.on(Events.MCPServersChanged, setMCPServers), | ||
| bridge.on(Events.BackgroundTasksChanged, (tasks: BackgroundTaskInfo[]) => setTasks(tasks)), |
There was a problem hiding this comment.
BackgroundTasksChanged carries only an array and is accepted without the session filtering used for stream events. Because SessionList allows overlapping asynchronous session selections, announcements for sessions A and B can arrive in one order while their history requests complete in another, leaving the transcript on one session and the task browser showing the other session's tasks; output and Stop can then be routed through a different currently attached runtime. Include the session ID in this notification and ignore updates that do not match the selected/loading session, or make the session switch and task snapshot atomic.
Useful? React with 👍 / 👎.
1 participant
Related Issue
No related issue. The problem is described below.
Problem
Kimi Code for VS Code can run background processes, subagents, and question tasks through the shared engine, but the extension does not expose their status or controls. Users cannot see that work is still running, inspect its output, stop it, or recover terminal task status when reopening a session.
What changed
Verification
pnpm --filter kimi-code test(330 tests)pnpm --filter kimi-code typecheckpnpm --filter kimi-code build:webviewpnpm lint(0 errors)pnpm --filter kimi-code package:platform -- --target darwin-arm64(VSIX package/static audit passed)Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.