fix(kosong): tolerate undefined model name in Anthropic profile matching - #3003
Open
silentiris wants to merge 1 commit into
Open
fix(kosong): tolerate undefined model name in Anthropic profile matching#3003silentiris wants to merge 1 commit into
silentiris wants to merge 1 commit into
Conversation
A malformed config entry (e.g. an unquoted dotted TOML key like [models.kimi-k2.7-code]) parses into a nested object that lacks the top-level model field. The v2 config schema marks model optional, so the entry reaches profile matching with undefined, crashing getModels with TypeError: Cannot read properties of undefined (reading 'toLowerCase'). matchKnownAnthropicModelProfile, matchUnknownClaudeProfile, and parseAnthropicModelVersion now return undefined/null for undefined input instead of throwing. Fixes MoonshotAI#2981
🦋 Changeset detectedLatest commit: 558b1a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #2981
Problem
A malformed config entry — e.g. an unquoted dotted TOML key like
[models.kimi-k2.7-code]— parses into a nested object that lacks the top-levelmodelfield. The v2 config schema marksmodeloptional, so the entry reaches profile matching withundefined, crashing thegetModelsbridge call withTypeError: Cannot read properties of undefined (reading 'toLowerCase').What changed
matchKnownAnthropicModelProfile,matchUnknownClaudeProfile, andparseAnthropicModelVersionnow returnundefined/nullforundefinedinput instead of throwing. This degrades to "no Anthropic profile" for the malformed entry, matching the behavior for unrecognized model names, and prevents the entiregetModelscall from failing.Checklist
gen-changesetsskill, or this PR needs no changeset.