Repository navigation
fix(games): Let the Play Games screens follow dark mode - #327
Merged
LisoUseInAIKyrios merged 1 commit intoOct 25, 2026
Merged
Conversation
GamePlayDataActivity and InGameUiActivity were pinned to light-only themes and their layouts hardcoded @android:color/black text, so the achievements and account screens stayed light whatever the system was set to. InGameUiActivity also called setTheme() after super.onCreate(), which was too late for the window and left the views on a different theme than the background. Move both onto the app's Theme.App and use textColorPrimary instead of a literal black. Refs microg#303.
1 task done
LisoUseInAIKyrios
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GamePlayDataActivity and InGameUiActivity were pinned to light-only themes and their layouts hardcoded @android:color/black text, so the achievements and account screens stayed light whatever the system was set to. InGameUiActivity also called setTheme() after super.onCreate(), which was too late for the window and left the views on a different theme than the background.
Move both onto the app's Theme.App and use textColorPrimary instead of a literal black.
Refs #303.