Repository navigation
fix(ui): Dark mode for the remaining light-only screens - #328
Merged
LisoUseInAIKyrios merged 2 commits intoOct 25, 2026
Merged
Conversation
Finishes the dark-mode pass started for the Play Games screens. The achievement, leaderboard and snapshot rows, assisted sign-in, account action, account settings and the place picker still used hardcoded light colours or light-only themes. Swap the colours for theme attributes, move the light-only activities onto Theme.App, and give the account action Compose content a MaterialTheme so it stops falling back to the light scheme.
AccountActionActivity moved to Theme.App, which left Theme.LoginBlue and its base style unused. Remove them and the two colours only they used; login_blue_theme_primary stays because the account action buttons use it.
rushiranpise
changed the title
LisoUseInAIKyrios
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the dark-mode pass started for the Play Games screens. The
achievement, leaderboard and snapshot rows, assisted sign-in, account
action, account settings and the place picker still used hardcoded light
colours or light-only themes.
Swap the colours for theme attributes, move the light-only activities onto
Theme.App, and give the account action Compose content a MaterialTheme so
it stops falling back to the light scheme.