Repository navigation
Fix print_tree crash on Windows consoles; add demo video to README - #2
Merged
Merged
Conversation
print_tree() printed box-drawing connectors (├── └── │) straight to stdout, raising UnicodeEncodeError on a default Windows PowerShell/cmd console (cp1252). When stdout's encoding can't represent the tree, it now prints ASCII connectors (|-- `-- |) instead; the returned string is unchanged. examples/tree_operations.py now lets the library print. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQFgoGFSPp6o1zCgAL9tb5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQFgoGFSPp6o1zCgAL9tb5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQFgoGFSPp6o1zCgAL9tb5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Protobuf.print_tree()raisedUnicodeEncodeErroron a default Windows PowerShell/cmd console (cp1252), because it printed the box-drawing connectors (├──,└──,│) straight to stdout. When stdout's encoding can't represent the tree, it now prints ASCII connectors (|--,`--,|) instead. The returned string is unchanged, andsys.stdoutis never reconfigured.examples/tree_operations.pynow lets the library do the printing, so all 6 examples run on cp1252.assets/videos/deproto-demo.mp4) with a GIF preview embedded at the top of the README (absolute URLs, so it also renders on PyPI)..gitignore: ignoreposts/.Testing
pytest tests/: 35 passed. Five new tests cover cp1252 stdout, utf-8 stdout, a stream with no encoding (StringIO), values cp1252 can't encode (replaced with?), andstdout=False.PYTHONIOENCODING=cp1252 python examples/<each>.py: all 6 examples run without errors.🤖 Generated with Claude Code
https://claude.ai/code/session_01VQFgoGFSPp6o1zCgAL9tb5