update conditions set for new CRV geometry#553
Open
rlcee wants to merge 1 commit into
Open
Conversation
Collaborator
|
☀️ The build tests passed at ec3c024.
N.B. These results were obtained from a build of this Pull Request at ec3c024 after being merged into the base branch at 173faea. For more information, please check the job page here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the database conditions set from Sim_best v1_4 to v1_5. I believe this change is only to accommodate a change to the CRV extracted geometry. I see it is included in EventNtuple, Offline/CrvResponse/test, and mu2e-trig-config/test so I added a few reviewers. Maybe @bonventre can advise how to migrate those uses away from this validation fcl