PTHMINT-133: Ensure fixed-point formatting in CartItem.add_tax_rate_p…#69
Open
zulquer wants to merge 1 commit into
Open
PTHMINT-133: Ensure fixed-point formatting in CartItem.add_tax_rate_p…#69zulquer wants to merge 1 commit into
zulquer wants to merge 1 commit into
Conversation
…ercentage to prevent 0E-10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in CartItem.add_tax_rate_percentage where converting the calculated tax rate ratio to a string via str(rating) could produce scientific exponential notation (such as '0E-10' or '1E-8') when handling Decimal objects with negative exponents.
When '0E-10' is sent in the API payload, it fails to match zero-tax rule keys (e.g. '0') in checkout_options.tax_tables.alternate, causing shopping cart validation errors.