Skip to content

fix(SparkleUpdateController): stop the background task tripping an executor check (refs #289) #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bcupello wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(SparkleUpdateController): stop the background task tripping an executor check (refs #289) #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Mythic/Utilities/SparkleUpdateController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,12 @@ final class SparkleUpdateController: NSObject, SPUUserDriver, ObservableObject {
backgroundQueue.schedule(
after: .init(.now()),
interval: .seconds(60 * 60 * 6)
) {
) { @Sendable in
// @Sendable is load-bearing: without it this non-Sendable closure inherits the
// enclosing MainActor isolation, so Swift 6 emits an executor check at its entry.
// It then runs on `backgroundQueue`, dispatch_assert_queue fails, and the app traps
// on launch (EXC_BREAKPOINT on the BackgroudEventService queue). The hop to the main
// actor is the Task below, which is where it belongs.
Task { @MainActor in
SparkleUpdateController.shared.checkForUpdates(userInitiated: false)
}
Expand Down