Repository navigation
Conversation
`AnyGame.init(from:)` decoded the storefront tag with `try`, so a tag the
running build does not recognise threw. `GameDataStore` decodes the whole
`[AnyGame]` array in one call and `UserDefaults.decodeAndGet` swallows any
error into `nil`, which the observer then reads as an empty library -- so a
single unreadable row discards every game from every other storefront too.
Measured on 0.6.0 by seeding `games` with one unknown storefront tag plus
one ordinary local game:
0.6.0 0 of 2 survive -- library wiped, local game included
this change 2 of 2 survive -- unknown tag degraded, local untouched
Worth shipping ahead of any new storefront case, because the build that
needs the tolerance is the older one: by the time a new tag exists on disk,
the release that cannot read it is already out.
`Game.storefront` on the base class logs instead of asserting, since a bare
`Game` is now a legitimate decode outcome rather than a programmer error.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnyGame.init(from:)decoded the storefront tag withtry, so a tag the running build does not recognise throws.GameDataStoredecodes the whole[AnyGame]array in one call andUserDefaults.decodeAndGetswallows any error intonil, which the observer reads as an empty library — so a single unreadable row discards every game from every other storefront too.Measured on 0.6.0 by seeding
gameswith one unknown storefront tag plus one ordinary local game:Worth shipping ahead of any new storefront case, because the build that needs the tolerance is the older one: by the time a new tag exists on disk, the release that cannot read it is already out.
Game.storefronton the base class logs instead of asserting, since a bareGameis now a legitimate decode outcome rather than a programmer error.