Skip to content

chore: avoid constant local run UUIDs - #60

Merged
ahmadki merged 1 commit into
mainfrom
rhewett/stack-05-run-uuid
Sep 4, 2026
Merged

chore: avoid constant local run UUIDs#60
ahmadki merged 1 commit into
mainfrom
rhewett/stack-05-run-uuid

Conversation

@rhewett-nv

Copy link
Copy Markdown
Collaborator

What does this PR do?

Generates missing run IDs once and uses them to derive distinct deterministic local run UUIDs.

Issues

N/A

Usage

from nemo.lens import NemoLensConfig, ensure_run_id

config = NemoLensConfig.from_env()
run_id = ensure_run_id(config)

# Before your PR is "Ready for review"

Pre checks:

- [x] I read the Contributor guidelines (/NVIDIA-NeMo/lens/blob/main/CONTRIBUTING.md).
- [x] All commits are signed off (git commit -s) per the DCO.
- [x] I added or updated tests under tests/ for any behavior change.
- [x] I ran pytest and pre-commit run --all-files locally; both pass.
- [x] I updated docs/ and README.md where behavior, configuration, or public API changed.
- [x] If this changes a lens public API symbol, I updated the cross-repo _fallbacks.py files in Megatron-LM / RL / Gym.

# Additional information

- The optional-dependency fallback surface is unchanged.

@rhewett-nv
rhewett-nv requested a review from ahmadki as a code owner September 4, 2026 15:18
@copy-pr-bot

copy-pr-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ahmadki ahmadki changed the title resources: avoid constant local run UUIDs chore: avoid constant local run UUIDs Sep 4, 2026
@ahmadki

ahmadki commented Sep 4, 2026

Copy link
Copy Markdown
Member

/ok to test 45aa84d

ahmadki
ahmadki previously approved these changes Sep 4, 2026
@ahmadki
ahmadki force-pushed the rhewett/stack-05-run-uuid branch from 45aa84d to 253413f Compare September 4, 2026 16:21
@ahmadki
ahmadki dismissed their stale review September 4, 2026 16:23

The merge-base changed after approval.

@ahmadki
ahmadki force-pushed the rhewett/stack-05-run-uuid branch from 253413f to 408b39f Compare September 4, 2026 16:25
@ahmadki

ahmadki commented Sep 4, 2026

Copy link
Copy Markdown
Member

/ok to test 408b39f

ahmadki
ahmadki previously approved these changes Sep 4, 2026
@ahmadki
ahmadki disabled the stack merge September 4, 2026 18:54
@ahmadki
ahmadki force-pushed the rhewett/stack-05-run-uuid branch from 408b39f to 7a5823f Compare September 4, 2026 18:55
@ahmadki
ahmadki dismissed their stale review September 4, 2026 18:59

The merge-base changed after approval.

@ahmadki
ahmadki force-pushed the rhewett/stack-05-run-uuid branch from 7a5823f to 737b45f Compare September 4, 2026 18:59
@ahmadki
ahmadki force-pushed the rhewett/stack-05-run-uuid branch from 737b45f to 132f84d Compare September 4, 2026 19:00
Base automatically changed from rhewett/stack-04-gpu-identity to main September 4, 2026 19:00
Signed-off-by: Russell Hewett <rhewett@nvidia.com>
@ahmadki
ahmadki force-pushed the rhewett/stack-05-run-uuid branch from 132f84d to d7f0b93 Compare September 4, 2026 19:01
@ahmadki
ahmadki merged commit b71263c into main Sep 4, 2026
4 checks passed
@ahmadki
ahmadki deleted the rhewett/stack-05-run-uuid branch September 4, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants