K8s/XCalibur Support - #579
Draft
sjayaram-nv wants to merge 1 commit into
Draft
Conversation
sjayaram-nv
marked this pull request as draft
August 3, 2026 06:16
sudostock
reviewed
Aug 5, 2026
| # Megatron-Bridge's common_utils.py expects. Without this wrapper each | ||
| # replica starts as a lone python process (WORLD_SIZE=1) and fails the | ||
| # parallelism divisibility check. | ||
| if executor.use_torchrun and cmd and cmd[0] == "python": |
Collaborator
There was a problem hiding this comment.
How is nsys profiling handled? For the slurm variant nsys is prepended to the start of the command.
sudostock
reviewed
Aug 5, 2026
| else: | ||
| logger.info("Cancelled WorkloadRun '%s'", name) | ||
|
|
||
| def post_run_cleanup(self, name: str) -> None: |
Collaborator
There was a problem hiding this comment.
Executor base class defines 'cleanup'. This function here doesn't appear to be called: https://github.com/NVIDIA-NeMo/Run/blob/main/nemo_run/core/execution/base.py#L189
sudostock
reviewed
Aug 5, 2026
| msg="", | ||
| ) | ||
|
|
||
| def log_iter( |
Collaborator
There was a problem hiding this comment.
Does this return all the logs or just rank 0? Kubeflow plugin has a specific check to avoid anything that isn't rank0.
sudostock
reviewed
Aug 5, 2026
| XCaliburPhase.IN_PROGRESS: AppState.RUNNING, | ||
| XCaliburPhase.SUCCEEDED: AppState.SUCCEEDED, | ||
| XCaliburPhase.FAILED: AppState.FAILED, | ||
| XCaliburPhase.UNKNOWN: AppState.PENDING, |
Collaborator
There was a problem hiding this comment.
Is unknown a transient state or could a job get stuck in this status?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| launch_path = os.path.join(self.job_dir, "launch.sh") | ||
| with open(launch_path, "w") as f: | ||
| f.write(script) | ||
| os.chmod(launch_path, 0o755) |
| val = labels.get("excalibur.nvidia.com/job") | ||
| if val and val != workloadrun_name: | ||
| return val | ||
| except json.JSONDecodeError: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch contains changes for adding the XCalibur executor backend to enable llm benchmarking runs in K8s.