Repository navigation
feat(runtime): mmap-backed zero-copy ASR weight loading #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+455
−232
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a81549b
feat(runtime): mmap-backed zero-copy ASR weight loading
ryanleary 78d96b4
fix(runtime): route RelPositionalEncoding's GGUF-path .pe write throu…
ryanleary 1720c95
test(asr): verify GGUFLoader's mmap path against the buffered-read path
ryanleary 71f1873
style: trim comments in the mmap zero-copy change down to 2 lines
ryanleary bdfb13a
simplify(test): drop GGUFLoader::tensor_names(), enumerate via gguf_g…
ryanleary 4b09593
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3bf8825
fix: address CodeRabbit review on #47
ryanleary decc3ca
fix(runtime): make CPU weights eligible for zero-copy mmap binding
ryanleary 6970b22
fix(runtime): harden GGUF mmap loading against bad files and mmap fai…
ryanleary 5640db2
build: use NEMO_SPEECH_LLAMA_CPP_DIR for llama-mmap, register mmap test
ryanleary File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| // llama-mmap.cpp (reused by GGUFLoader) logs via LLAMA_LOG_*; this supplies | ||
| // the one symbol it needs without linking llama-impl.cpp (format() clash). | ||
| #include <cstdarg> | ||
| #include <cstdio> | ||
|
|
||
| #include "llama-impl.h" | ||
| #include "runtime.h" | ||
|
|
||
| void | ||
| llama_log_internal(ggml_log_level level, const char* fmt, ...) { | ||
| char buf[1024]; | ||
| va_list args; | ||
| va_start(args, fmt); | ||
| vsnprintf(buf, sizeof(buf), fmt, args); | ||
| va_end(args); | ||
| ggml_runtime::log_internal(level, __FILE__, __LINE__, "llama_mmap", "%s", buf); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.