Repository navigation
fix(license): add the parakeet.cpp notice to llama_log_shim.cpp - #75
VitorAMJorge wants to merge 1 commit into
Conversation
scripts/check_license_headers.py requires every file under src/runtime/ggml/ to carry the parakeet.cpp notice, as THIRD_PARTY_NOTICES.md lists that directory as derived from it. llama_log_shim.cpp, added in NVIDIA#47, has only the NVIDIA header, so the license-headers pre-commit hook fails on main and on every pull request based on it. The shim formats llama.cpp's log calls into the parakeet-derived ggml_runtime::log_internal (logging.cpp), so this follows the directory's convention. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Vitor A. M. Jorge <vitor.jorge@widelabs.com.br>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
[Low impact] The PR appears safe to merge. SummaryAdds the parakeet.cpp attribution notice to
Reviews (1) · Last reviewed commit: "fix(license): add the parakeet.cpp notic..." · Reviewed by Greptile |
Fixes #74
The core idea of this PR is to unblock pre-commit blocks caused by License header omission
Adds the parakeet.cpp notice (the same block as in logging.cpp) to src/runtime/ggml/llama_log_shim.cpp. Header only, no code change. The shim forwards llama.cpp log calls to the parakeet-derived ggml_runtime::log_internal, so this follows the directory's convention; if you consider it not derived, an exemption in scripts/check_license_headers.py would be the alternative.
python3 scripts/check_license_headers.py: "All tracked first-party source files have the required license header."
pre-commit run --all-files on a fresh clone of the branch: all 11 hooks pass.
AI use: Claude Opus 5.5 helped trace the failing license check to the missing header, fix it, and run the pre-commit validation. It initially proposed exempting the file from the check instead; after reviewing the code, I concluded the parakeet.cpp notice belongs there, following the directory's convention.