Skip to content

fix(license): add the parakeet.cpp notice to llama_log_shim.cpp - #75

Open
VitorAMJorge wants to merge 1 commit into
NVIDIA:mainfrom
VitorAMJorge:fix/llama-log-shim-license-header
Open

VitorAMJorge wants to merge 1 commit into
NVIDIA:mainfrom
VitorAMJorge:fix/llama-log-shim-license-header

Conversation

@VitorAMJorge

Copy link
Copy Markdown

Fixes #74

The core idea of this PR is to unblock pre-commit blocks caused by License header omission

Adds the parakeet.cpp notice (the same block as in logging.cpp) to src/runtime/ggml/llama_log_shim.cpp. Header only, no code change. The shim forwards llama.cpp log calls to the parakeet-derived ggml_runtime::log_internal, so this follows the directory's convention; if you consider it not derived, an exemption in scripts/check_license_headers.py would be the alternative.

python3 scripts/check_license_headers.py: "All tracked first-party source files have the required license header."
pre-commit run --all-files on a fresh clone of the branch: all 11 hooks pass.

AI use: Claude Opus 5.5 helped trace the failing license check to the missing header, fix it, and run the pre-commit validation. It initially proposed exempting the file from the check instead; after reviewing the code, I concluded the parakeet.cpp notice belongs there, following the directory's convention.

scripts/check_license_headers.py requires every file under
src/runtime/ggml/ to carry the parakeet.cpp notice, as
THIRD_PARTY_NOTICES.md lists that directory as derived from it.
llama_log_shim.cpp, added in NVIDIA#47, has only the NVIDIA header, so the
license-headers pre-commit hook fails on main and on every pull request
based on it. The shim formats llama.cpp's log calls into the
parakeet-derived ggml_runtime::log_internal (logging.cpp), so this
follows the directory's convention.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Vitor A. M. Jorge <vitor.jorge@widelabs.com.br>
@copy-pr-bot

copy-pr-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 2bdfb03 and dc6b7a2.

📒 Files selected for processing: 1
  • src/runtime/ggml/llama_log_shim.cpp

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Documentation
    • Updated third-party acknowledgements to identify Parakeet-derived content and include its MIT license notice. The relevant source attribution and licensing terms are now more clearly documented. This update does not change app features, functionality, or behavior.

The logging shim now includes comments that attribute portions of the file to parakeet.cpp and identify its copyright holder, MIT license, and third-party notices file.

Changes: GGML license notice

Layer / File(s) Summary
Add source attribution
src/runtime/ggml/llama_log_shim.cpp
Comments now attribute portions of the file to parakeet.cpp and identify the copyright holder, MIT license, and third-party notices file.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to dc6b7

The requested license attribution is complete with no runtime or merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: adding the Parakeet license notice to llama_log_shim.cpp.
Description check Passed The description directly explains the license-header fix, its purpose, affected file, validation results, and relationship to Issue #74.
Linked Issues check Passed Issue #74 requires the Parakeet-derived notice in src/runtime/ggml/llama_log_shim.cpp so scripts/check_license_headers.py passes. The PR adds that notice. The supplied validation reports that the …
Out of Scope Changes check Passed The change adds only four license-header lines to src/runtime/ggml/llama_log_shim.cpp. The supplied summary reports no code or exported-entity changes. The change directly addresses issue #74 and co…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Full details: Linked Issues check

Explanation

Issue #74 requires the Parakeet-derived notice in src/runtime/ggml/llama_log_shim.cpp so scripts/check_license_headers.py passes. The PR adds that notice. The supplied validation reports that the license-header check passes for all tracked first-party source files.

Full details: Out of Scope Changes check

Explanation

The change adds only four license-header lines to src/runtime/ggml/llama_log_shim.cpp. The supplied summary reports no code or exported-entity changes. The change directly addresses issue #74 and contains no demonstrated unrelated work.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Adds the parakeet.cpp attribution notice to src/runtime/ggml/llama_log_shim.cpp.

  • The logging shim now carries its parakeet.cpp credit and MIT notice.

Reviews (1) · Last reviewed commit: "fix(license): add the parakeet.cpp notic..." · Reviewed by Greptile

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pre-commit license-headers check fails on main (src/runtime/ggml/llama_log_shim.cpp)

1 participant