-
Notifications
You must be signed in to change notification settings - Fork 41
feat(qualification): add MiniMax-H3 ACC and PERF #1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chaofengw-nv
wants to merge
30
commits into
NVIDIA:main
Choose a base branch
from
chaofengw-nv:feat/minimax-h3-acc-perf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+801
−138
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
376bbe0
feat(minimax-h3): support variable-length prompts
chaofengw-nv 29f6dd2
fix(minimax-h3): bound position builder complexity
chaofengw-nv 572c053
fix(minimax-h3): preserve padding validation contract
chaofengw-nv 27959a7
feat(qualification): add MiniMax-H3 accuracy and perf
chaofengw-nv 73eaff9
fix(ci): classify AVGen scorer test impact
chaofengw-nv a4fc367
feat(qualification): replace MiniMax-H3 quality scorer
chaofengw-nv 04b71c2
fix(qualification): handle SigLIP pooled features
chaofengw-nv ebb428e
fix(qualification): pin SigLIP preprocessing
chaofengw-nv 1733fc5
fix(ci): update MiniMax-H3 qualification totals
chaofengw-nv 74fd7e7
fix(qualification): align MiniMax-H3 bundle capacity
chaofengw-nv 52fc392
DCO Remediation Commit for chaofengw <chaofengw@nvidia.com>
chaofengw-nv ae7590e
fix(qualification): limit MiniMax-H3 quality smoke
chaofengw-nv 20ddcd6
refactor(qualification): isolate MiniMax-H3 adapters
chaofengw-nv 0f96361
test(validation): assert binding cardinality structurally
chaofengw-nv 505d285
chore: merge current main into MiniMax-H3 qualification
chaofengw-nv be97449
fix(validation): format model-owned scorer results
chaofengw-nv 7a19540
fix(validation): record metric-only precision
chaofengw-nv 2ce321d
DCO Remediation Commit for chaofengw <chaofengw@nvidia.com>
chaofengw-nv 3a983df
DCO Remediation Commit for chaofengw <chaofengw@nvidia.com>
chaofengw-nv ca4692c
chore: merge current main into MiniMax-H3 qualification
chaofengw-nv 5b0fbef
fix(qualification): separate MiniMax-H3 ACC and PERF
chaofengw-nv 4385fa4
Merge remote-tracking branch 'github/main' into feat/minimax-h3-acc-perf
chaofengw-nv f9ce347
fix(validation): verify pinned VBench metadata
chaofengw-nv 7b8aaa8
fix(minimax_h3): align manifest bundle capacity
chaofengw-nv 177e7a6
chore: sync MiniMax-H3 qualification with main
chaofengw-nv 1fcc7f4
fix(perf): align media timing contracts
chaofengw-nv 2f5f368
fix(minimax_h3): harden video parity metrics
chaofengw-nv 5f6eb65
fix(ci): classify video parity tooling
chaofengw-nv a96d71b
fix(qualification): simplify MiniMax-H3 ACC scope
chaofengw-nv 80b4325
fix(validation): restore MiniMax-H3 pass rate
chaofengw-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: NVIDIA/TensorRT-Model-Connect
Length of output: 50386
🤖 get_repo_knowledge executed:
get_repo_knowledge NVIDIA/TensorRT-Model-Connect /tmp/coderabbit-repo-knowledge/nvidia-tensorrt-model-connect-dd446d04/architecture /tmp/coderabbit-repo-knowledge/nvidia-tensorrt-model-connect-dd446d04/conventionsLength of output: 47610
🏁 Script executed:
Repository: NVIDIA/TensorRT-Model-Connect
Length of output: 12624
🏁 Script executed:
Repository: NVIDIA/TensorRT-Model-Connect
Length of output: 303
🏁 Script executed:
Repository: NVIDIA/TensorRT-Model-Connect
Length of output: 50386
🏁 Script executed:
Repository: NVIDIA/TensorRT-Model-Connect
Length of output: 5242
🏁 Script executed:
Repository: NVIDIA/TensorRT-Model-Connect
Length of output: 9379
Handle modular pipeline state outputs.
When a modular configuration omits
output_fields, the pinnedModularPipeline.__call__returns aPipelineState, not aMapping. Itsvideosvalue is available through attribute access, but this code checks onlyimagesandframes; the mapping fallback cannot findvideos. The summary can therefore reportmedia_count: 0. Read configured or default output names withgetattr, or requireoutput_fields. Add a regression test withoutoutput_fields.🤖 Prompt for AI Agents
Source: MCP tools