Skip to content

fix(test_scenario): stop apply_params_set writing NUM_NODES into cmd_args #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmirF194 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

fix(test_scenario): stop apply_params_set writing NUM_NODES into cmd_args #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/cloudai/_core/test_scenario.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,10 @@ def apply_params_set(self, action: dict[str, Any], env_params: dict[str, Any] |
for key, value in full_action.items():
if key.startswith("extra_env_vars."):
tdef.extra_env_vars[key[len("extra_env_vars.") :]] = value
elif key == "NUM_NODES":
# Handled below via new_tr.num_nodes; cmd_args has no such field, and CmdArgs'
# extra="allow" would otherwise let this create a phantom attribute on it.
continue
else:
attrs = key.split(".")
obj = tdef.cmd_args
Expand Down
1 change: 1 addition & 0 deletions tests/test_cloudaigym.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,7 @@ def test_params_set(setup_env: tuple[TestRun, Runner], num_nodes: int):
assert new_tr.test.extra_env_vars[key[len("extra_env_vars.") :]] == value
elif key == "NUM_NODES":
assert new_tr.num_nodes == value
assert "NUM_NODES" not in cmd_args
else:
assert cmd_args[key] == value

Expand Down