Skip to content

Make Windows pathfinder dynamic library searches architecture-aware#2393

Open
isVoid wants to merge 2 commits into
NVIDIA:mainfrom
isVoid:codex/pathfinder-windows-arch-search-ctk-next
Open

Make Windows pathfinder dynamic library searches architecture-aware#2393
isVoid wants to merge 2 commits into
NVIDIA:mainfrom
isVoid:codex/pathfinder-windows-arch-search-ctk-next

Conversation

@isVoid

@isVoid isVoid commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Make Windows dynamic-library search paths architecture-aware for x64 and ARM64.
  • Keep CUDA 13 aggregate-wheel paths ordered before CUDA 12 component-wheel paths.
  • Add explicit Windows architecture detection and reject unsupported Python platform tags.
  • Derive legacy lookup tables from the architecture-aware descriptor catalog.

Why

CUDA Toolkit 13.4 installs Windows binaries in architecture-specific directories such as bin/x64 and bin/arm64. CUDA 13 wheels likewise use architecture-specific directories under nvidia/cu13/bin, while CUDA 12 component wheels retain their existing package-specific layouts.

Validation

  • ruff check passed for all changed Python files.
  • ruff format --check passed for all changed Python files.
  • Focused cuda-pathfinder suite: 812 passed.

@isVoid isVoid added this to the cuda.pathfinder next milestone Jul 20, 2026
@isVoid isVoid added the cuda.pathfinder Everything related to the cuda.pathfinder module label Jul 20, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@isVoid isVoid self-assigned this Jul 20, 2026
@isVoid isVoid added the enhancement Any code-related improvements label Jul 20, 2026
@isVoid
isVoid requested review from leofang and rwgk July 20, 2026 21:22
@isVoid

isVoid commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

/ok to test

@isVoid, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@isVoid

isVoid commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 1d0a111

@github-actions

Copy link
Copy Markdown

@isVoid
isVoid force-pushed the codex/pathfinder-windows-arch-search-ctk-next branch from 1d0a111 to 3247072 Compare July 21, 2026 16:38
@isVoid

isVoid commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 3247072

}
SITE_PACKAGES_LIBDIRS_LINUX = SITE_PACKAGES_LIBDIRS_LINUX_CTK | SITE_PACKAGES_LIBDIRS_LINUX_OTHER

# Historical table exports represent the original x64 catalog.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: What should we list here? Historically it's only listing the x64 catalog. But should we instead list all available items?

import sysconfig


class UnsupportedWindowsArchError(RuntimeError):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just call it UnsupportedArchError in case we want to use it elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.pathfinder Everything related to the cuda.pathfinder module enhancement Any code-related improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants