test(cuda.core): isolate pending-call saturation cleanup#2406
Merged
Andy-Jost merged 3 commits intoJul 23, 2026
Conversation
Run the process-global queue probe in a subprocess and explicitly drain its synthetic callbacks so parallel free-threaded tests cannot contaminate one another.
Andy-Jost
added
bug
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Driveby comment: We could add a dependency on |
Pass the finalization timeout into the child so process isolation does not depend on importing test helpers from the temporary working directory.
Contributor
Author
|
/ok to test |
Contributor
Author
Oh, it looks like |
Andy-Jost
marked this pull request as ready for review
July 22, 2026 21:49
Preserve subprocess isolation while adopting the latest safe-close retry behavior for pending cleanup.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Isolate the CPython pending-call saturation probe so its process-global queue cannot contaminate other tests running concurrently under free-threaded Python. Explicitly drain the synthetic no-op callbacks before exercising cuda.core's existing retry path.
Changes
test_pending_call_queue_saturation_preserves_cleanupin a subprocess using the current Python executable.Py_MakePendingCallsafter saturating the queue and before creating the second graph attachment that retries cleanup scheduling.Test Coverage
python -m py_compile cuda_core/tests/graph/test_graph_definition_lifetime.pypre-commit run --all-filesRelated Work