fix: reject oversized cuTile partition dimensions - #1383
Closed
Rachit2323 wants to merge 1 commit into
Closed
Rachit2323 wants to merge 1 commit into
Rachit2323 wants to merge 1 commit into
Conversation
Signed-off-by: Rachit2323 <atreyrachit23@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
i32ABIFixes #1382.
Why
Partition and map dimensions enter the host API as
usize, but the compiler metadata and kernel ABI usei32. The previous grid check allowed the fullu32range, while lateras i32casts changed values abovei32::MAXinto negative dimensions.Testing
cargo fmt -p cutile -p cutile-macro -- --checkgit diff --checkcargo test -p cutile --lib partition_metadata_rejects_dimensions_above_i32_maxcould not run locally because this checkout has no CUDA 13+ toolkit; the build stopped incuda-bindings/build.rsbefore compiling the changed crates