add new status file to signal daemons startup - #913
Merged
Conversation
tariq1890
force-pushed
the
add-driver-daemons-status-file
branch
2 times, most recently
from
August 10, 2026 21:54
54e0dbc to
0a021f8
Compare
Contributor
Author
|
Related gpu-operator PR - https://github.com/NVIDIA/gpu-operator/pull/2727/changes |
shivamerla
reviewed
Aug 10, 2026
rahulait
reviewed
Aug 10, 2026
shivamerla
reviewed
Aug 10, 2026
Contributor
|
@tariq1890 in the PR description add details about why a sentinel file is not enough in this case and how that causes backward compatibility issue. |
tariq1890
force-pushed
the
add-driver-daemons-status-file
branch
2 times, most recently
from
August 11, 2026 00:26
3ee93e1 to
07c7f18
Compare
shivamerla
reviewed
Aug 11, 2026
| echo "Starting NVIDIA fabric manager daemon..." | ||
| nv-fabricmanager -c /usr/share/nvidia/nvswitch/fabricmanager.cfg || return 1 | ||
| fi | ||
| echo "Ready" > /run/nvidia/validations/.driver-daemons-status |
Contributor
There was a problem hiding this comment.
can you add a method for this too, set_daemon_status "Ready"
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
force-pushed
the
add-driver-daemons-status-file
branch
from
August 11, 2026 01:34
07c7f18 to
78094f7
Compare
Contributor
|
These changes look good to me. |
shivamerla
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new status file called
/run/nvidia/validations/.driver-daemons-status. This file can be leveraged by components downstream who need to ensure that the driver daemons like persistenced, fabricmanager, vgpu-topologyd have come up before performing any other operations