[state-dcgm-exporter][clusterpolicy] remove pods from Role - #2726
Merged
Conversation
The ClusterRole already provides get, list and watch privileges to the dcgm-exporter daemonset. The privileges in the namespace-scoped are therefore redundant and unnecessary. Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya and
shivamerla
as code owners
August 10, 2026 19:59
|
coverage: 38.385%. remained the same — dcgm-exporter-rm-pods-role into main |
Contributor
There was a problem hiding this comment.
LGTM.
Technically, the reason this works is because DCGM exporter uses the pod-resources socket for GPU -> Pod mapping, so it doesn't require pods RBAC. And the ClusterRole is only rendered if pod enrichment is enabled, so with or without enrichment enabled this never did anything.
rajathagasthya
approved these changes
Aug 10, 2026
tariq1890
enabled auto-merge
August 10, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ClusterRole already provides get, list and watch privileges to the dcgm-exporter daemonset. The privileges in the namespace-scoped are therefore redundant and unnecessary.