Skip to content

Keep a Singularity post move inside the destination directory - #551

Open
SashaMIT wants to merge 1 commit into
NVIDIA:mainfrom
SashaMIT:fix/singularity-post-move-basename
Open

SashaMIT wants to merge 1 commit into
NVIDIA:mainfrom
SashaMIT:fix/singularity-post-move-basename

Conversation

@SashaMIT

@SashaMIT SashaMIT commented Sep 30, 2026 •

Copy link
Copy Markdown

Closes #550

copy(src=['src/a'], dest='/opt', _post=True) prints mv /a /opt/src/a.

copy(src=['/home/user/a'], dest='/opt', _post=True) prints mv /a /home/user/a.

The file is staged as the source basename (/a). The move then joins the destination with the full source path. A relative directory is kept. An absolute source replaces /opt.

The destination now uses the basename too. src=['a', 'b'] with dest /opt is still mv /a /opt/a and mv /b /opt/b. A single file still moves to the dest path as given.

test_post_nested_source_singularity is red on tip (mv /a /opt/src/a) and green after. test_copy.Test_copy passes (48 tests).

The staged file is the source basename, but the move joined the full
source path. src/a landed in /opt/src/a, and an absolute source left
/opt entirely.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Singularity post move joins the full source path

1 participant