-
Notifications
You must be signed in to change notification settings - Fork 0
SCC-5473: Replace displayPacked fields with new display components #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
7emansell
merged 14 commits into
SCC-5472/add-contributornametitle-to-filter
from
SCC-5473/replace-display-packed
Sep 2, 2026
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
401f658
Contributor name title filter
7emansell 695c36b
start of new display situation
7emansell 47d1706
renaming label
7emansell fb74471
Actually should it have period
7emansell 7f3f6b6
no period
7emansell a5bef41
start of new display situation
7emansell 6060501
renaming label
7emansell 9b5f505
Actually should it have period
7emansell 0e36bff
no period
7emansell d16e5df
Merge branch 'SCC-5473/replace-display-packed' of github.com:NYPL/dis…
7emansell 3adfc3f
update to 08-25 index
7emansell 6c8edc3
updating fixtures for new index
7emansell bbebaa0
Updates tests according to recent changes (working around item locati…
7emansell a500529
merge accepting all current
7emansell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there not always a period between name and title? getting back to our convo from yesterday.