Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
dxparameter to the low-level SSP projection interface. The use case for this is typically when the projection is onto a grid of a different resolution than therho_filteredgrid, althoughdxwill still default to the pixel step of therho_filteredgrid. This way, the user has better control ofR_smoothing = alg.smoothing_radius * dxwithout having to pick a dimensionless rescaling of thesmoothing_radius. Perhaps if the list of target points is grid-like,dxshould default to that spacing, although the choice to maketarget_pointsa list of points was made based on the interpolation API from FastInterpolations.jl before the recent 0.4.16 release that allows aGriddedQuery.