Repository navigation
Delete unreferenced legacy autosegmentation code - #3
Open
ehennestad wants to merge 1 commit into
Open
ehennestad wants to merge 1 commit into
ehennestad wants to merge 1 commit into
Conversation
Removes the able and cnmf autosegmentation packages, the template options file and the autosegmentation copy of the EXTRACT imviewer plugin. Nothing in the module, in NANSEN or in the tests references them; NANSEN's RoiManager keeps an empty case for cnmf. The suite2p and extract run functions and their Options classes stay because that interactive dispatch still calls them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch R2 from the module review: dead code, stacked on #2. Pure deletions; no behaviour changes.
Deleted (10 files, no references anywhere)
+autosegmentation/+able(three files; usedsubplotandtic, and held two of the analyzer's unreachable-code sites)+autosegmentation/+cnmf(five files; held two "output may be unset" sites)+autosegmentation/+template/defaultOptions.m+autosegmentation/+extract/ImviewerPlugin.m, a 187-line copy ofui.imviewer.EXTRACTthat had diverged by 163 linesReferences were checked in the module, in NANSEN core on the removal branch, and in the tests. NANSEN's RoiManager has an empty
case 'cnmf'in its autosegmentation switch and calls nothing from these packages.Kept on purpose
+autosegmentation/+suite2p/*and+autosegmentation/+extract/{run.m, @Options}stay: RoiManager's interactive autosegmentation reachessuite2p.run,extract.runandsuite2p.Optionsthrough a wildcard import. They can go when that dispatch is reworked in the core-decoupling follow-up.Not changed: the manifest entries
The review suggested moving the Neurodata Without Borders and Brain Observatory Toolbox entries out of the module manifest. That is not a module-only change:
nansentools.generateRequirementsTxtwrites every community-toolbox entry regardless ofrequirementLevelandinstallMissingAddonsinstalls every resolved entry, so adding them to NANSEN core would install matnwb and the Brain Observatory Toolbox in every NANSEN CI run and everynansen_install, while removing them from the module alone would stop installing matnwb for two-photon users and break the tutorial loader, which looks "Brain Observatory Toolbox" up by name. Left as-is and noted in the review document for a decision.🤖 Generated with Claude Code