Skip to content

Revert #845 lock hardening and #865 zip/nginx changes (write_lock worker failures on k8s/NFS) - #872

Merged
brianlball merged 3 commits into
developfrom
revert-845-865-develop
Aug 17, 2026
Merged

Revert #845 lock hardening and #865 zip/nginx changes (write_lock worker failures on k8s/NFS)#872
brianlball merged 3 commits into
developfrom
revert-845-865-develop

Conversation

@brianlball

Copy link
Copy Markdown
Contributor

Why

Recurring write_lock worker failures on the k8s/NFS cluster running 3.10.0-179 images (which carry #845 + the #865-equivalent #863). Bisect branch 179D-310 (= develop@Jul16 + #852 + #853, i.e. develop minus #845/#865, on OS 3.10) ran clean on the cluster (3.10.0-179D-test images). This PR makes develop match the known-good configuration.

Mechanism (theory consistent with sim logs): on NFS, flock state is server-authoritative but File.exist? is subject to attribute/negative-dentry caching, so #845's lock_abandoned? probe (2 probes 3s apart) falsely declares the lock holder dead during the receipt-visibility lag, deletes the live lock, fails datapoints, and triggers a re-extract herd over a live analysis dir.

What

Kept intact: #852 (BSON cap / terminal state) and #853 (nil-DataPoint guards — verified 3× if d.nil? in resque job). The #845/#853 hardening specs are deleted with the revert (they test #845 code).

Known trade-offs

🤖 Generated with Claude Code

brianlball and others added 3 commits August 17, 2026 13:48
…dlock and stale-job re-dispatch (#845)"

This reverts commit 821fcf7.
Push run 31833777972 failed only on these: morris zip 205865 > 200000
cap, sobol 41451 > 40000. Result CSV/plot sizes drift on full rserve
rebuilds; widen upper caps ~15% (200k->230k, 40k->46k) so the docker
job can reach docker-upload.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
(cherry picked from commit 9b93a5b)
@brianlball
brianlball merged commit 3bdce37 into develop Aug 17, 2026
5 checks passed
@brianlball
brianlball deleted the revert-845-865-develop branch August 17, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant