Revert #845 lock hardening and #865 zip/nginx changes (write_lock worker failures on k8s/NFS) - #872
Merged
Merged
Conversation
Push run 31833777972 failed only on these: morris zip 205865 > 200000 cap, sobol 41451 > 40000. Result CSV/plot sizes drift on full rserve rebuilds; widen upper caps ~15% (200k->230k, 40k->46k) so the docker job can reach docker-upload. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 9b93a5b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Recurring
write_lockworker failures on the k8s/NFS cluster running3.10.0-179images (which carry #845 + the #865-equivalent #863). Bisect branch179D-310(= develop@Jul16 + #852 + #853, i.e. develop minus #845/#865, on OS 3.10) ran clean on the cluster (3.10.0-179D-testimages). This PR makes develop match the known-good configuration.Mechanism (theory consistent with sim logs): on NFS,
flockstate is server-authoritative butFile.exist?is subject to attribute/negative-dentry caching, so #845'slock_abandoned?probe (2 probes 3s apart) falsely declares the lock holder dead during the receipt-visibility lag, deletes the live lock, fails datapoints, and triggers a re-extract herd over a live analysis dir.What
Kept intact: #852 (BSON cap / terminal state) and #853 (nil-DataPoint guards — verified 3×
if d.nil?in resque job). The #845/#853 hardening specs are deleted with the revert (they test #845 code).Known trade-offs
lookupcache=positivemount opt, probe persistence > cache staleness, inode revalidation after flock).🤖 Generated with Claude Code