Skip to content

fix: disable unsafe native scroll packets#80

Merged
DjDeveloperr merged 1 commit into
mainfrom
fix/disable-native-scroll-packets
Jun 20, 2026
Merged

fix: disable unsafe native scroll packets#80
DjDeveloperr merged 1 commit into
mainfrom
fix/disable-native-scroll-packets

Conversation

@DjDeveloperr

@DjDeveloperr DjDeveloperr commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Route browser wheel/trackpad scroll over the simulator screen through synthetic touch drags instead of private native scroll HID packets
  • Reject legacy scroll control messages before they can reach SimulatorKit/Indigo scroll packet dispatch
  • Update REST docs to steer API clients toward touch drag scroll sequences

Testing

  • npm run --prefix packages/client typecheck
  • npm --prefix packages/client test -- --run src/app/controlMessages.test.ts src/features/viewport/viewportMath.test.ts src/features/viewport/viewportWheel.test.ts
  • npm run --prefix packages/client test
  • cargo fmt --manifest-path packages/server/Cargo.toml
  • cargo check --manifest-path packages/server/Cargo.toml
  • cargo clippy --manifest-path packages/server/Cargo.toml --all-targets -- -D warnings
  • cargo test --manifest-path packages/server/Cargo.toml
  • npm run build:client
  • npm run build:cli
  • npx prettier --check docs/api/rest.md packages/client/src/app/AppShell.tsx
  • git diff --check
  • Restarted local 4310 service from rebuilt binary; served bundle is index-DNuVHG2P.js
  • Sent a stale { "type": "scroll" } control packet to a booted iPhone simulator; simulator remained Booted/Streaming

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
simdeckciproxy bf90be3 Commit Preview URL

Branch Preview URL
Jun 20 2026, 05:35 AM

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 503da1ba-b320-41ce-aa4a-f6a5bc15e3c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/disable-native-scroll-packets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DjDeveloperr DjDeveloperr merged commit 68cc6d3 into main Jun 20, 2026
12 checks passed
@DjDeveloperr DjDeveloperr deleted the fix/disable-native-scroll-packets branch June 20, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant