Generate fragments for interfaces - #955
Open
ryanflegel wants to merge 1 commit into
Open
Conversation
ryanflegel
requested review from
asibross,
iparadiso,
iuliiasobolevska,
jjacobs44,
kilink,
kzwang,
paulbakker and
srinivasankavitha
as code owners
August 31, 2026 15:28
ryanflegel
commented
Aug 31, 2026
| prefix: String, | ||
| processedEdges: Set<Pair<String, String>>, | ||
| queryDepth: Int, | ||
| fragment: Boolean = false, |
Author
There was a problem hiding this comment.
We need to know if the projection is for a fragment so that we don't generate fragments within fragments.
| when (type) { | ||
| is InterfaceTypeDefinition -> { | ||
| document | ||
| .getDefinitionsOfType(InterfaceTypeDefinition::class.java) |
Author
There was a problem hiding this comment.
This is the heart of the change -- we now include other interface types in addition to concrete object types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate fragments projection methods for interfaces.
Currently dgs-codegen only generates fragment projection methods for concrete types and union member types, however it is also valid to do fragment projections on interfaces.
This fixes #855.