Thread dump viewer by JugadK · Pull Request #14 · Netflix/eclipse-jifa

JugadK · 2025-06-13T01:55:21Z

Once our npm cache comes backup ill post a picture, but this adds a "grid" thread dump viewer to jifa

Copilot

Pull Request Overview

Adds a grid-based thread dump viewer to the Jifa UI and exposes a new endpoint in the analyzer to supply row data.

New ThreadViewerGrid.vue component renders threads in a sortable table and emits selections.
Updated ThreadDump.vue to fetch thread rows, integrate the grid view, and display code snippets for the selected thread.
Backend support via ThreadDumpRow model and rows() method in ThreadDumpAnalyzer to supply thread metadata and line ranges.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File	Description
frontend/src/components/threaddump/ThreadViewerGrid.vue	New Vue component for grid-based thread listing and selection
frontend/src/components/threaddump/ThreadDump.vue	Integrated grid view, fetch logic, and details panel
analysis/thread-dump/src/main/java/org/eclipse/jifa/tda/model/ThreadDumpRow.java	Added data model for a thread dump row
analysis/thread-dump/src/main/java/org/eclipse/jifa/tda/ThreadDumpAnalyzer.java	Added `rows()` to expose thread row data; adjusted imports

Copilot · 2025-06-13T01:57:58Z

  'javaMonitors',
-  'callSiteTree'
+  'callSiteTree',
+  'Table View',


activeNames includes the display title 'Table View', but the corresponding <el-collapse-item> uses the name 'emptyBox'. This mismatch prevents the grid tab from activating. Update activeNames to use 'emptyBox' or rename the collapse-item to 'Table View'.

Copilot · 2025-06-13T01:57:58Z

+
+  console.log(thread)
+
+  if (lineNumberStart && lineNumberEnd) {


Checking these values with a truthiness test fails when lineNumberStart is 0 (falsy). Use explicit checks like if (lineNumberStart != null && lineNumberEnd != null) { to handle zero-based lines.

Suggested change

if (lineNumberStart && lineNumberEnd) {

if (lineNumberStart != null && lineNumberEnd != null) {

Copilot · 2025-06-13T01:57:59Z

+    /**
+     * @return rows of a thread dump table
+     */
+     public List<ThreadDumpRow> rows(PagingRequest paging) {


The paging parameter is currently unused. Either implement pagination logic inside this method or remove the parameter to keep the API signature accurate.

Copilot · 2025-06-13T01:57:59Z

+import java.util.*;
+import java.util.stream.Collectors;


[nitpick] Avoid wildcard imports; explicitly import only the needed classes to improve readability and prevent accidental dependencies.

Suggested change

import java.util.*;

import java.util.stream.Collectors;

import java.util.ArrayList;

import java.util.HashMap;

import java.util.List;

import java.util.Map;

import java.util.Optional;

import java.util.Set;

import java.util.function.Function;

import java.util.stream.Collectors;

import java.util.stream.Collectors;

Copilot · 2025-06-13T01:58:00Z

+import lombok.Data;
+
+@Data


Because there's an explicit all-args constructor, Lombok won’t generate a no-argument constructor. Add @NoArgsConstructor (or a manual default constructor) if your JSON serialization framework requires it.

Suggested change

import lombok.Data;

@Data

import lombok.Data;

import lombok.NoArgsConstructor;

@Data

@NoArgsConstructor

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jasonk000 · 2025-06-25T17:11:45Z

-import org.eclipse.jifa.tda.model.Monitor;
-import org.eclipse.jifa.tda.model.RawMonitor;
-import org.eclipse.jifa.tda.model.Snapshot;
+import org.eclipse.jifa.tda.model.*;


Can we undo this please?

jasonk000 · 2025-06-25T17:18:01Z

 import org.eclipse.jifa.common.domain.vo.PageView;
 import org.eclipse.jifa.common.util.PageViewBuilder;
 import org.eclipse.jifa.tda.enums.MonitorState;
+import org.eclipse.jifa.tda.enums.OSTreadState;


nit: typo

We should submit a separate PR upstream to rename it.

jasonk000 · 2025-06-25T17:28:38Z

+     */
+     public List<ThreadDumpRow> rows(PagingRequest paging) {
+
+         List<ThreadDumpRow> threadDumpRows = new ArrayList<>(snapshot.getJavaThreads().stream().map(t -> {


style:

We can add static functions and/or local functions somewhere to do this conversion. For example, a ThreadDumpRow(JavaThread javaThread) constructor or a static ThreadDumpRow fromJavaThread(JavaThread javaThread).

Though, it's a bit clunky having that in the Model, so maybe somewhere here.

jasonk000 · 2025-06-25T17:29:05Z

+             return new ThreadDumpRow(t.getName(), t.getId(), t.getOsThreadState(), 0, new Frame[]{}, t.getElapsed(), t.getCpu(), t.getLineStart(), t.getLineEnd());
+         }).toList();
+
+         threadDumpRows.addAll(nonJavaThreadDumpRows);


You should be able to simply construct the paging component using PageViewer, see the function buildVThreadPageView for an example.

jasonk000 · 2025-06-25T17:37:36Z

+         List<ThreadDumpRow> threadDumpRows = new ArrayList<>(snapshot.getJavaThreads().stream().map(t -> {
+
+             Frame[] frames = null;
+             int length = 0;
+
+             if (t.getTrace() != null) {
+                 frames = t.getTrace().getFrames();
+                 length = frames.length;
+             }
+
+             return new ThreadDumpRow(t.getName(), t.getId(), t.getOsThreadState(), length, frames, t.getElapsed(), t.getCpu(), t.getLineStart(), t.getLineEnd());
+         }).toList());
+
+         List<ThreadDumpRow> nonJavaThreadDumpRows = snapshot.getNonJavaThreads().stream().map(t -> {
+             return new ThreadDumpRow(t.getName(), t.getId(), t.getOsThreadState(), 0, new Frame[]{}, t.getElapsed(), t.getCpu(), t.getLineStart(), t.getLineEnd());
+         }).toList();
+
+         threadDumpRows.addAll(nonJavaThreadDumpRows);


This approach generates quite a bit of intermediary list garbage. Consider something like this instead:

Stream<ThreadDumpRow> javaRows = snapshot.getJavaThreads().stream().map(....); Stream<ThreadDumpRow> nonJavaRows = snapshot.getNonJavaThreads().stream().map(....); Stream<ThreadDumpRow> allRows = Stream.concat(javaRows, nonJavaRows); // consider implementing paging here on the stream List<ThreadRumpRow> threadDumpRows = allRows.toList();

jasonk000 · 2025-06-25T17:38:14Z

  'javaMonitors',
-  'callSiteTree'
+  'callSiteTree',
+  'Table View',


Table View doesn't have the java camelCase approach.

jasonk000 · 2025-06-25T17:38:46Z

+
+  console.log(thread)
+
+  if (lineNumberStart && lineNumberEnd) {


jasonk000 · 2025-06-25T17:39:14Z

  });
+
+  request('rows').then((threadsData) => {
+    console.log(threadsData);


nit: is this required?

jasonk000 · 2025-06-25T17:41:38Z

+  if (selectedThread.value) {
+    return row === selectedThread.value ? 'selected-row' : '';
+  } else {
+    return rowIndex === 0 ? 'selected-row' : '';


Maybe not clear what the intent is here, are we defaulting to first-row selected deliberately?

jkhajuria added 3 commits June 12, 2025 18:52

add thread dump row class

a5d1b95

add new endpoint for getting thread dump rows

5f2bd43

new thread dump grid view

7127d6a

JugadK requested review from Copilot and jasonk000 June 13, 2025 01:55

Copilot AI reviewed Jun 13, 2025

View reviewed changes

Update frontend/src/components/threaddump/ThreadDump.vue

c4a2824

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jasonk000 requested changes Jun 25, 2025

View reviewed changes

	if (lineNumberStart && lineNumberEnd) {
	if (lineNumberStart != null && lineNumberEnd != null) {

-import java.util.*;
-import java.util.stream.Collectors;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.Collectors;

Uh oh!

Conversation

JugadK commented Jun 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants