feat(dpi): refactor DPI section - #1889
Draft
m-dilorenzi wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a rework on the DPI rule management around application groups and an ordered, first-match-wins rule list, replacing the old flat schema where every rule was a device plus a list of applications or protocols, all evaluated in parallel.
Main changes
blockand the newallow.list-popular,list-devicesand the global exemption CRUD, replaced by an Allow rule at the top of the list./etc/config/dpion the first boot after the upgrade. Legacy rules are kept with their behaviour frozen verbatim, global exemptions become Allow rules, unsupported rules are dropped with a log line naming them.dpi-configorders the actions by priority, refuses to emit a rule that would produce an invalid criteria, and still handles the old schema for a box whose migration has not run yet.