Repository navigation
feat(harness)!: read the model and MCP servers from the agent document's gateway sections - #19
Merged
yash-kark merged 1 commit intoOct 28, 2026
Conversation
Merged
yash-kark
force-pushed
the
feat/p1-sdk-9-agent-doc-sections
branch
5 times, most recently
from
October 28, 2026 17:17
e0c93ea to
f0c4350
Compare
Base automatically changed from
feat/p1-sdk-8-mcp-by-name
to
feat/p1-sdk-2-remove-events-sink
October 28, 2026 17:19
…t's gateway sections The agent document (after old-CAS #164) is read from llm.config.model and mcp.servers; guardrails is not read. The model-gateway fields and refusals, mcp_mode and DEFAULT_MCP_MODE are removed; every binding is attached to the engine. For gitagent a model without a provider prefix gets openai:. BREAKING CHANGE: ResolvedAgent loses gateway_* fields, has_native_gateway and mcp_mode; legacy document fields are no longer read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yash-kark
force-pushed
the
feat/p1-sdk-9-agent-doc-sections
branch
from
October 28, 2026 17:19
f0c4350 to
e329912
Compare
yash-kark
merged commit Oct 28, 2026
2beb231
into
feat/p1-sdk-2-remove-events-sink
1 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: 9 of 10 (base #18). Plan:
.claude/plans/p1-sdk-egress-routes.mdphase 9 (C1; D19, D20). This has to be in the stage images before old-CAS #164 deploys (X14).What changes
model_ofreturnsllm.config.model, orNonewhenllmorconfigis null or the model is blank.Nonemeans the image's own model is used.parse_bindingsnow takes themcpsection:servers→ no bindings;mcp must be an object/mcp.servers must be a list;mcp.servers[i];provider,needs_your_connectionandstandard_server_idare ignored.mcp_mode,DEFAULT_MCP_MODEandbuild_mcp_servers(mcp_mode=).ResolvedAgentlosesgateway_type,gateway_base_url,gateway_completions_url,has_native_gatewayandmcp_mode. The generic-gateway and unresolved-binding refusals are gone; theorchestrationrefusal stays.dispatch_model: for gitagent, a model without aprovider:prefix always getsopenai:. The Claude engine still strips a prefix.model,model_gateway,mcp_servers,mcp_modeorrai_policy_id. A pre-#164 document resolves with no model and no MCP servers.guardrailsis not read.llmkongclaude-sonnet-4-5,guardrails,mcp).Tests
ruffclean;mypyat 18 (baseline);pytest -m "not integration": 608 passed.test_model_from_llm_configtest_null_llm_uses_the_image_model(7 shapes)test_legacy_fields_are_ignoredtest_guardrails_section_ignoredtest_bound_mcp_servers_are_resolvedtest_a_binding_without_a_name_refuses_the_agenttest_parses_mcp_sectionand the malformed-section casestest_kong_model_reaches_the_claude_engine_untouched🤖 Generated with Claude Code