test(unpack): register per-fixture native cases under portable names - #588
Merged
Merged
Conversation
The fixture matrix used testing::Combine, whose default parameter name carries spaces and parentheses in the GetParam() comment. CMake test discovery before 3.x and the pinned 4.2.3 register that form rather than the custom suffix, so the native CPU inventory could not find the Kvm_<fixture> case names on the Linux runner. Use one flat case struct with a PrintTo that emits the single-token name, as the other value-parameterized native tests do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #579. The fixture matrix used
testing::Combine, whose default parameter name carries spaces and parentheses in theGetParam()comment. The pinned CMake 4.2.3 test discovery (local and the Linux KVM runner) registers that form rather than the customKvm_<fixture>suffix, so the native CPU inventory gate could not find the requiredBackends/UnpackFixture.RecoversEntrySectionsAndImports/Kvm_*names and the KVM native CPU run failed at the inventory check (the unpacking itself passed). The Windows CMake happened to register the clean names, so WHP passed.Fix: use one flat case struct with a
PrintTothat emits the single-tokenBackend_Fixturename, as the other value-parameterized native tests (WindowsDeferred, user-execution) already do. ctest now registers.../Kvm_PlainLZMAetc. on every CMake version; the required-name gate is satisfied and the cases run unchanged (verified locally, and KVM native CPU CI dispatched).