Repository navigation
fix(x86): keep GCC warning-clean feature builds - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC rejects compressed x86 feature-decoder statements under the existing
-Werror=misleading-indentationpolicy. Expand the affected functions using LLVM formatting without changing decoding tokens or warning flags. Fix the corresponding strict-build issues in x86 unit tests: ambiguous statements, a shadowed scratch name, register-array parameter extents, and combined mnemonic/operand buffer sizes.Validation: the actual GCC native component target builds; all 70 x86 unit tests pass under GCC 15 and Clang 21. The production decoder has identical preprocessed compiler token streams before and after (868,392 tokens, SHA-256
b74a8faacf4c26048794385f3b27495ac2a13212a662a3079e120df3072d0092). Existing test bytes and assertions are retained. The x86-onlycstestlink error discovered during broader validation is fixed in #10. Its complete GCC build, 76 unit/negative checks and 444 x86 detail instructions now pass.