tell the user which master a plugin is missing and why - #24206
Merged
Merged
Conversation
A check that returns allowSuppress false is shown even when its notification id carries a suppression, so a check that is not hideable cannot be silenced by an entry the user set earlier. part of LAZ-1030
The index reads the collection's slug and revision off the container mod, and falls back to the membership rules' reference tags for mods whose attributes do not carry them. part of LAZ-1039
Every unavailable master is classified as an install state the user can fix or as the plugin list contradicting the game folder, phrased the way LOOT does. The contradictions go to telemetry once per master per state, and the health check cannot be suppressed, so a stale suppression cannot hide an error-grade run. part of LAZ-1030 part of LAZ-1039
erri120
reviewed
Sep 16, 2026
part of LAZ-1030
erri120
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Missing Masters health check now says why each master is unavailable, in LOOT's words:
not-installedandnot-enabledare the user's install state and stay warnings, whileremoved-externally,unscannedandnot-deployedonce nothing is left to rescan mean the plugin list disagrees with the game folder, and are errors. Those cases go to telemetry once per master per state, with the mod and collection on both sides of the dependency, so a broken collection revision is identifiable from one span. A sort that fails on an unloaded master names it the same way, and the check cannot be hidden.Stacked on #24196.
part of LAZ-1030
part of LAZ-1039