keep the health checks running after a collection install - #24319
Merged
Merged
Conversation
A collection install holds off the plugins-changed, settings-changed, mod-activated and mod-installed checks while it runs. The hold is released however the install ends: closing the review screen, a cancel or pause, a restart of an install that ended incomplete, and an install that never starts (no archive or profile, Cancel at the game-version prompt, or an error). A check that fires while held is recorded and runs once the last hold lifts, so a missing master the collection brings in is reported without another change to the plugins. withSuppressedTests lives in test_runner/suppressedTests.ts and accepts any PromiseLike. part of LAZ-1022
Aragas
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collections case in LAZ-1022: after a completed collection install, the checks held off during the install (Missing Masters among them) did not run again until Vortex restarted. The install takes the hold through the test runner's
withSuppressedTests, and the review screen'sclose(), the way a successful install ends, never released it.The hold is released however the install ends:
close(), a cancel or pause, a restart of an install that ended incomplete, and an install that never starts (no archive or profile, Cancel at the game-version prompt, or an error). A check that fires while held is recorded by the runner and replayed once the last hold lifts, so a missing master the collection brings in is reported without another change to the plugins.withSuppressedTestslives intest_runner/suppressedTests.tsand accepts anyPromiseLike.part of LAZ-1022