Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exe-version is a pure TypeScript PE parser now, but it still returned an empty string outside Windows. So on Linux the game version was always empty, and anything comparing exe versions (script extender installer, FNIS, the LOOT version report) got nothing.
This drops the platform checks. Added two tests that read divine.exe from the BG3 extension, since the existing ones use System32 files and only run on Windows.
Checked in the app with the Cyberpunk extension pointed at a real install: getInstalledVersion now returns 2.3.1.0 instead of "".