Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux, an EACCES from forcePerm shows the "Access denied" dialog saying Windows will show a UAC prompt, with a "Give permission" button. Clicking it fails with
ReferenceError: os is not defined, because permissions.getUserId() usesoswithout requiring it on non-Windows, and the elevation itself goes through ShellExecuteEx anyway.Outside Windows the dialogs now only offer Cancel and Retry, without the UAC sentence, and ensureDirWritableAsync returns the original error instead of trying to elevate.
Reproduced in the app with forcePerm writing into a read-only directory, before and after. Added a test for the forcePerm dialog buttons.