Removed negation operator for @aria attributes - #2
Open
NickSdot wants to merge 1 commit into
Open
Conversation
Owner
Author
|
If no one has any concerns I will merge this soon. |
NickSdot
force-pushed
the
remove-negation-operator
branch
from
September 7, 2026 03:53
3820cbb to
9510428
Compare
NickSdot
force-pushed
the
remove-negation-operator
branch
from
September 7, 2026 04:43
9510428 to
20b7174
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe to fully hide aria-attributes on
falseis such a rare case that the negation operator, with all the noise and complexity it adds, does not add enough value. In cases where an aria-attribute should not be renderednullcan be passed.Opinions welcome.