Skip to content

Telio DNS forwarder rename - #1926

Merged
tomasz-grz merged 2 commits into
mainfrom
telio_dns_cleanup
Aug 21, 2026
Merged

Telio DNS forwarder rename#1926
tomasz-grz merged 2 commits into
mainfrom
telio_dns_cleanup

Conversation

@tomasz-grz

@tomasz-grz tomasz-grz commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Problem

In preparation for adding TCP Forwarder, the raw forwarder naming is a little non-descriptive.

Solution

  • Rename RawForwarder module to UdpForwarder
  • Some logging cleanup

☑️ Definition of Done checklist

  • Commit history is clean (requirements)
  • README.md is updated
  • Functionality is covered by unit or integration tests

@tomasz-grz tomasz-grz self-assigned this Aug 3, 2026
@tomasz-grz
tomasz-grz force-pushed the telio_dns_cleanup branch 2 times, most recently from 9eeea6f to 1c2eaf5 Compare August 4, 2026 09:57
@tomasz-grz tomasz-grz changed the title Telio dns cleanup Telio DNS forwarder rename Aug 4, 2026
@tomasz-grz
tomasz-grz marked this pull request as ready for review August 4, 2026 10:00
@tomasz-grz
tomasz-grz requested a review from a team as a code owner August 4, 2026 10:00
lcruz99
lcruz99 reviewed Aug 4, 2026
View reviewed changes
Comment thread crates/telio-dns/src/nameserver.rs
lcruz99
lcruz99 reviewed Aug 4, 2026
View reviewed changes
Comment thread crates/telio-dns/src/nameserver.rs
@lcruz99

lcruz99 commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rename feature flag to use_new_forwarder

Will use_new_forwarder be accurate in 1 year from now? IMHO is not much better than use_raw_forwarder.

@tomasz-grz

tomasz-grz commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Will use_new_forwarder be accurate in 1 year from now

@lcruz99 😪 I hope not.. but wouldn't be surprised..

It will require some time for all apps to fully test it and completely migrate, then it will be removed

@lcruz99

lcruz99 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Oh I see, this is a temporary flag, however I'm not fond of use_new_forwarder, do you consider it an improvement over use_raw_forwarder?

@tomasz-grz

tomasz-grz commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

@lcruz99 if you prefer we can keep the use_raw_forwarder, or do you have any other recommendation?
Just thought of renaming it together with the module, but strong attachments to either.

@lcruz99

lcruz99 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@tomasz-grz no idea for now, just not use_new_forwarder 👀

@tomasz-grz

tomasz-grz commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

@lcruz99 Reverted

@djkarwowski

djkarwowski commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@tomasz-grz regarding the reverted use_new_forwarder name, can you please also update the PR description accordingly? :)

djkarwowski
djkarwowski approved these changes Aug 18, 2026
View reviewed changes

@djkarwowski djkarwowski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tomasz-grz
tomasz-grz added this pull request to the merge queue Aug 18, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 18, 2026
@lcruz99

lcruz99 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

+1

@tomasz-grz
tomasz-grz added this pull request to the merge queue Aug 21, 2026
Merged via the queue into main with commit fcc3e8d Aug 21, 2026
63 checks passed
@tomasz-grz
tomasz-grz deleted the telio_dns_cleanup branch August 21, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcruz99 lcruz99 lcruz99 left review comments
@djkarwowski djkarwowski djkarwowski approved these changes

Assignees

@tomasz-grz tomasz-grz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomasz-grz @lcruz99 @djkarwowski