feat: let Google and Fairphone devices inherit the brand's unlock - #16
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Feature, a small one on top of #12.
Overview
#12 put a policy line on every Google and Fairphone page but left the Unlock fact itself saying Unknown. Now a device with no answer of its own takes the brand's (Google
conditional, Fairphoneyes) and says it's brand policy, both on the page and as a "brand" tag in the tables. Anything a device file says still wins, and every other brand stays Unknown. That moves 21 devices off Unknown, 611 down to 590.Two data tweaks came with it. Google's note said "from 2015 on", but the AOSP page covers older devices too (
fastboot oem unlock) and 12 of the 16 that inherit are from before 2015, so it now just says Pixel and Nexus devices. The Fairphone 2 gets its own line instead of inheriting, becuase Fairphone's guide covers every model except that one - LineageOS installs on it straight over fastboot with no unlock step.The one I'm least sure about is
seed, the Android One 2nd gen. It's filed under Google so it picks up Conditional, but the AOSP page only talks about Nexus and Pixel. I left it rather than add an opt-out field for a single phone.Issue Number
None, follows on from #12.
Additional Info
The model test that was meant to go red if anyone wired inheritance up now checks it the right way round: a device's own value beats the brand, unknown takes the brand's, and a brand with no
unlockleaves it alone. Reverting the model change turns the middle one red.