Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ The files in `upstream/` get rewritten by a bot every Monday, so any change you

## Reporting what works

The [form](https://github.com/NotAFlightRisk/android-rom-compat/issues/new?template=report-feature.yml) is the easy way. Pick a device and ROM, set whatever you've tried, and a bot opens a pull request for you with your name on the commit. If something's missing or doesn't add up, it comments on the issue saying what - just edit the issue and it'll try again. The "Report" link on each ROM row of a device page fills in the first two fields for you.
The [form](https://github.com/NotAFlightRisk/android-rom-compat/issues/new?template=report-feature.yml) is the easy way. Pick a device and ROM, set whatever you've tried, and a bot opens a pull request for you with your name on the commit. If something's missing or doesn't add up, it comments on the issue saying what - just edit the issue and it'll try again. The "Report" link on each ROM row of a device page puts the device, its codename and the ROM in the title, so you can copy them across.

Rather do it by hand? Add a `features` section to `data/support/<codename>/<rom>.yml`, making the file if it's not there yet. Anything you leave out shows as unknown, which is fine.

Expand Down
6 changes: 4 additions & 2 deletions src/lib/table.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,10 @@ export const reportedFeatures = (features, rows) =>
export const featuresFrom = (features, rows, origin) =>
features.filter(({ key }) => rows.every((row) => row.cells[key].origin === origin));

export const reportUrl = (device, rom) =>
`${issueUrl('report-feature')}&device=${device.key}${rom ? `&rom=${rom.key}` : ''}`;
export const reportUrl = (device, rom) => {
const title = `[Report]: ${device.title} (${device.key})${rom ? ` on ${rom.name}` : ''}`;
return `${issueUrl('report-feature')}&title=${encodeURIComponent(title)}`;
};

export const deviceSearchText = (device) =>
[device.title, ...device.codenames, ...(device.aliases ?? [])].join(' ').toLowerCase();
Expand Down
Loading