Repository navigation
Conversation
…or complaints Postmark sends "ID" as a JSON number in Bounce and SpamComplaint webhook payloads (e.g. "ID": 692560173), but PostmarkWebhookPayload.ID was a string, so json.Unmarshal failed and the endpoint returned 400. Postmark now verifies webhooks on creation by posting sample events and rejects the webhook on any non-2xx (HTTP 422, ErrorCode 1364), so "Register webhook" fails for Postmark integrations. Real bounce/complaint events are rejected for the same reason. - PostmarkWebhookPayload.ID: string -> json.Number (accepts numbers and string-encoded numbers, so existing payloads keep working). - SpamComplaint: Postmark carries the event time in "BouncedAt"; fall back to it when "ComplainedAt" is absent instead of using time.Now(). - Regression tests with the official Postmark sample payloads.
Author
|
Some extra context and evidence for this fix: What users seeIn the Postmark integration, clicking Register webhook shows: Server log: Postmark's verification response (per trigger)Delivery passes because its payload has no Reproduction (v41.0)POST the official samples to
So Verification of this PR
Thanks for Notifuse! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…or complaints
Postmark sends "ID" as a JSON number in Bounce and SpamComplaint webhook payloads (e.g. "ID": 692560173), but PostmarkWebhookPayload.ID was a string, so json.Unmarshal failed and the endpoint returned 400.
Postmark now verifies webhooks on creation by posting sample events and rejects the webhook on any non-2xx (HTTP 422, ErrorCode 1364), so "Register webhook" fails for Postmark integrations. Real bounce/complaint events are rejected for the same reason.