Conversation
Signed-off-by: Neil Kale <263453039+kalectory@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Megatron policy and reference forward passes return token arrays only from collection ranks instead of materializing outputs that dispatch immediately discards.
WorkerDispatch.forwardretrieves every rank'sWorkerOutput, thenWorkerOutput.catselects only collection ranks. With context parallelism and long sequences, the unused Python float lists still incur serialization, transfer, deserialization, and garbage collection. Runtime stack samples showed the head deserializing these results with active Python GC after worker GPU computation ended.The five-line change uses the existing
is_collection_dp_rank()predicate after_forward_logprobsfinishes. Every rank still executes the same distributed forward; dispatch still waits for every result and propagates worker exceptions. Collection-rank values are unchanged. No retries, timeouts, or numerical computation changes.Validation: formatting and secret hooks passed. In a separate process with the deployed Megatron dependencies, the old policy method failed the non-collection materialization check and all eight candidate cases passed (policy/reference × collection/CP/TP/PP rank). The check executed the candidate methods and committed test function directly with mocked forward results; it did not initialize Ray or run GPU collectives. Full pytest/GPU validation and an end-to-end performance measurement remain pending. Not deployed to the active run.