Repository navigation
Conversation
Derive ItemIsMenu from primary action availability and synchronize callback presence when the action changes. Emit NewTitle alongside PropertiesChanged so Plasma refreshes its cached activation mode. Protect click callback access across native and JNI threads. Add D-Bus regression coverage for activation, host cache refresh, and context menus, and run it in CI. Verified with automated tests and manual testing on Fedora KDE.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On KDE Plasma, a tray with a primary action still opens its menu on left click because the Linux SNI backend always advertises
ItemIsMenu=true. This change derives the property from primary action availability, so left click invokes the action when present and opens the menu otherwise. Right-click menu behavior is preserved.The Kotlin manager now synchronizes callback presence when the action is added or removed. These transitions emit both
PropertiesChangedandNewTitle, which lets Plasma refresh its cachedItemIsMenu. Native callback access and JNI references are protected while callbacks are updated.Validation:
ktlintCheckpassed.The new regression tests are included in CI.