[18.0][FIX] base_bank_from_iban: Broader except for _get_bank_from_iban - #288
Open
qgroulard wants to merge 1 commit into
Open
[18.0][FIX] base_bank_from_iban: Broader except for _get_bank_from_iban#288qgroulard wants to merge 1 commit into
qgroulard wants to merge 1 commit into
Conversation
Our goal is to provide a fall back for any wrongly formatted iban. Instead of catching every possible formatting issue one by one, let's catch their parent exception class.
Author
|
Hi @Andrii9090-tecnativa, this PR might interest you. |
pedrobaeza
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our goal is to provide a fall back for any wrongly formatted iban.
Instead of catching every possible formatting issue one by one, let's catch their parent exception class.
I stumbled onto this issue because Odoo is using 17 characters long french iban in unit tests, while french iban are 27 characters long.
Hence, I have noticed that
schwifty.exceptions.InvalidLengthis missing from the list of expected schwifty errors, like others.